Skip to content

Handle bounding boxes with some zero length axes#36

Closed
K-Meech wants to merge 2 commits intofiji:masterfrom
K-Meech:bounding_box_2d
Closed

Handle bounding boxes with some zero length axes#36
K-Meech wants to merge 2 commits intofiji:masterfrom
K-Meech:bounding_box_2d

Conversation

@K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Jun 22, 2024

Handles drawing bounding boxes where some axes may have zero length (avoiding NegativeArraySizeException) - details in the corresponding issue: #35

@K-Meech K-Meech closed this Oct 2, 2025
@ctrueden
Copy link
Member

ctrueden commented Oct 6, 2025

@K-Meech Ack! Is there a technical reason you closed this, or is it just frustration at the lack of attention?

Edit: Oh! Is it because #38 is a more updated version of this?

@K-Meech
Copy link
Contributor Author

K-Meech commented Oct 7, 2025

Thanks @ctrueden ! Yes #38 is a more updated solution to this problem.

I realised that this fix didn't cover all the situations that could trigger NegativeArraySizeException. It handles when axes have length of 0, but not other situations that cause lineLength - first to be negative inside of makeLine. For example, adding a plane with a small rotation relative to one axis could still give NegativeArraySizeException with the code in this PR. #38 hopefully covers all situations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants